Merged
Conversation
Collaborator
You underestimate yourself, sir 😃 The tests look much cleaner now! |
Collaborator
|
Checks need to be triggered here somehow. |
AshesITR
requested changes
Jun 13, 2024
IndrajeetPatil
approved these changes
Jun 14, 2024
AshesITR
approved these changes
Jun 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2604 +/- ##
==========================================
- Coverage 98.15% 97.96% -0.19%
==========================================
Files 125 126 +1
Lines 5738 5748 +10
==========================================
- Hits 5632 5631 -1
- Misses 106 117 +11 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2603.
Just to give an example of what's available to us with an R 4.0 dependency. I'm sure there's more. I'm also fairly confident tests will fail here 😅